-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): Introduction to textlint #986
Changes from 9 commits
f8e9410
f845d3c
86d8f8b
6c73bdf
fbbee27
5d8c952
bdf3cbb
b67f7fe
58caa8e
af0e20c
9f0a516
f5dc602
4cb6f1f
90eb566
aa7e19d
0d565e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: Checks for Japanese Documentation | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
paths: | ||
- "website/src/content/docs/ja/**" | ||
|
||
jobs: | ||
ja-docs-check: | ||
name: Checks on JA Docs | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout PR Branch | ||
uses: actions/checkout@v4 | ||
- name: Cache pnpm modules | ||
uses: actions/cache@v3 | ||
with: | ||
path: ~/.pnpm-store | ||
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}- | ||
- uses: pnpm/action-setup@v2.2.4 | ||
with: | ||
version: 8 | ||
- name: Install libraries | ||
working-directory: website | ||
run: pnpm i | ||
- name: Run textlint | ||
working-directory: website | ||
run: pnpm textlint |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
name: Website preview | ||
env: | ||
VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }} | ||
VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} | ||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
# Cancel jobs when the PR is updated | ||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} | ||
cancel-in-progress: true | ||
jobs: | ||
preview-deploy: | ||
runs-on: ubuntu-latest | ||
environment: Website deployment | ||
# Check if the event is not triggered by a fork | ||
if: github.event.pull_request.head.repo.full_name == github.repository | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Install Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
- name: Cache pnpm modules | ||
uses: actions/cache@v3 | ||
with: | ||
path: ~/.pnpm-store | ||
key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}- | ||
- uses: pnpm/action-setup@v2.2.4 | ||
with: | ||
version: 8 | ||
- name: Install toolchain | ||
uses: moonrepo/setup-rust@v1 | ||
- name: Install wasm-pack | ||
uses: jetli/wasm-pack-action@v0.4.0 | ||
with: | ||
version: 'latest' | ||
- name: Install Vercel CLI | ||
run: npm install --global vercel@latest | ||
- name: Pull Vercel Environment Information | ||
working-directory: website | ||
run: vercel pull --yes --environment=preview --token=${{ secrets.VERCEL_TOKEN }} | ||
- name: Build WASM module for the web | ||
run: wasm-pack build --out-dir ../../packages/@biomejs/wasm-web --target web --scope biomedev crates/biome_wasm | ||
- name: Install libraries | ||
working-directory: website | ||
run: pnpm i | ||
- name: Build JS | ||
working-directory: website | ||
run: pnpm build:js | ||
- name: Run textlint | ||
working-directory: website | ||
run: pnpm textlint | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would like you to create a new file like "ja-translation.yaml" and add this step to that file. ref: https://github.com/biomejs/biome/blob/main/.github/CODEOWNERS There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the review! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can this file diff be removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @unvalley remove: Run textlint from website deploy ci ← fixed in |
||
- name: Deploy Project Artifacts to Vercel | ||
run: vercel deploy --prebuilt --token=${{ secrets.VERCEL_TOKEN }} | ||
working-directory: website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yossydev
I think we don't need this workflow file, because we are currently using netlify. And netlify provides the preview feature by itself.