chore: use the same Prettier version in Biome
#864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
README mentions to use pnpm so removed this file
There was a problem hiding this comment.
We use pnpm workspace, so this file should be removed.
There was a problem hiding this comment.
run.js uses the npm's node_modules packages inside. We can switch to pnpm in the future, but I left it as it is for now
ematipico
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some places still used old Prettier version, so all places use the same Prettier version
v3.1.0.Test Plan
node run.jsworks inbenchmarkdirnode prepare_tests.js <Prettier Repo>works incrates/biome_js_formatter/tests/specs/prettierpnpm startworks inwebsite