Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(diagnostics): use ParseDiagnostic instead #640

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Oct 31, 2023

Summary

I removed some indirection and deleted a struct that we don't need anymore. Now we use ParseDiagnostic directly to emit messages from the parsing phase.

Test Plan

Current snapshots should stay the same and tests should pass.

@ematipico ematipico temporarily deployed to Website deployment October 31, 2023 12:13 — with GitHub Actions Inactive
@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages labels Oct 31, 2023
@github-actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13454 13454 0
Failed 4190 4190 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

@ematipico ematipico force-pushed the refactor/diagnostics-parser branch from a6e6046 to 0d602f6 Compare October 31, 2023 12:45
@ematipico ematipico temporarily deployed to Website deployment October 31, 2023 12:45 — with GitHub Actions Inactive
@github-actions github-actions bot added the A-Project Area: project label Oct 31, 2023
@ematipico ematipico temporarily deployed to Website deployment October 31, 2023 12:46 — with GitHub Actions Inactive
@ematipico ematipico merged commit 72c2bee into main Oct 31, 2023
@ematipico ematipico deleted the refactor/diagnostics-parser branch October 31, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser A-Project Area: project L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant