Allow trailing commas and comments in biome.json config file JSON schema #5278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using trailing commas or comments in the biome.json/biome.jsonc files in VS Code, warnings/errors are shown in the editor and Problems pane.
Apparently, these warnings/errors can be controlled by using custom VS Code JSON schema extension fields
allowTrailingComma
andallowComments
, seen here: https://github.com/microsoft/vscode/blob/201df9b990f871fad842dc9a6211bfa84c663e53/src/vs/base/common/jsonSchema.ts#L89A solution suggested by a VS Code maintainer that seems to work is to use those custom fields in JSON schemas that declare they support trailing commas and comments.
VS Code does internally for its settings.json files, etc. and it would be nice if biome declared them as allowed since the biome tool allows them when parsing its JSON config file.