Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parse/html): split HtmlName into HtmlTagName and HtmlAttributeName #5267

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Mar 3, 2025

Summary

Does what it says in the title. The reason for this change is that there are different rules for tag names and attribute names when normalizing the casing, and this will help resolve those things.

Test Plan

Snapshots updated.

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-HTML Language: HTML labels Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50388 50388 0
Passed 49073 49073 0
Failed 1315 1315 0
Panics 0 0 0
Coverage 97.39% 97.39% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6641 6641 0
Passed 2229 2229 0
Failed 4412 4412 0
Panics 0 0 0
Coverage 33.56% 33.56% 0.00%

ts/babel

Test result main count This PR count Difference
Total 798 798 0
Passed 706 706 0
Failed 92 92 0
Panics 0 0 0
Coverage 88.47% 88.47% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18658 18658 0
Passed 14309 14309 0
Failed 4349 4349 0
Panics 0 0 0
Coverage 76.69% 76.69% 0.00%

@dyc3 dyc3 force-pushed the html-split-tag-attr-names branch from 1daefa2 to 111dc19 Compare March 3, 2025 19:00
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward! I suppose we'll see the results of the refactor soon :)

Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #5267 will not alter performance

Comparing html-split-tag-attr-names (111dc19) with main (b9d438b)

Summary

✅ 97 untouched benchmarks

@dyc3 dyc3 merged commit ff2b6b2 into main Mar 3, 2025
14 checks passed
@dyc3 dyc3 deleted the html-split-tag-attr-names branch March 3, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants