feat(linter): implement useSymbolDescription
#5232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
CodSpeed Performance ReportMerging #5232 will not alter performanceComparing Summary
|
siketyan
approved these changes
Mar 2, 2025
ematipico
reviewed
Mar 2, 2025
crates/biome_js_analyze/src/lint/nursery/use_symbol_description.rs
Outdated
Show resolved
Hide resolved
Comment on lines
69
to
73
| "Provide a description for the symbol." | ||
| }, | ||
| ) | ||
| .note(markup! { | ||
| "Explicit description can be useful in debugging and making purpose of the symbol clearer." |
There was a problem hiding this comment.
Please follow the rule pillars: https://biomejs.dev/linter/#rule-pillars
In this case the first one is missing, which should be at line 69. The phrase at line 69 is the third pillar.
minht11
force-pushed
the
feat/lint-symbol-description
branch
from
a9d1e65 to
14729a4
Compare
ematipico
reviewed
Mar 2, 2025
minht11
force-pushed
the
feat/lint-symbol-description
branch
from
ed36ad5 to
335a4d6
Compare
ematipico
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement symbol-description. Makes sure that
Symbol()constructor always has description param.Closes #5231
Test Plan