-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update bench #3739
refactor: update bench #3739
Conversation
Can't we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a npm leftover, you also need to remove the old package-lock.json
does this close #2100? |
f730d59
to
b37b46e
Compare
Yes. Thanks for the reminder! |
0199dbd
to
910eca3
Compare
Good suggestion. Done :) |
2b4fa8c
to
42f7e86
Compare
9ab46a7
to
1b408cc
Compare
There is a typo in |
PR to fix the typo are welcome :) |
Summary
The benchmark was broken.
This PR fixes it and improves the benchmark in several ways:
As CLI parser, I picked commander.js because it is battle-tested and has no dependencies.
ts-eslint
andts-biome
that adds Typescript ESLint rules (without rules that require type info).Note: I disabled
parallel-prettier
because it crashes on Node 22.Fixes #2100
Test Plan
I tested manually the new script on Linux.