fix(console): print <br />
when having a newline
#3701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The HTML emitted by our adapter was causing a parsing error when used inside MDX files.
It turns out that MDX doesn't like
\n\n
inside HTML. I think it's a reasonable parsing error.This PR fixes the issue by changing
\n
to a<br />
. While<br>
should be accepted, MDX doesn't like it, so it's safer to use<br />
instead.This PR changes the existing adapter and renames it. Unfortunately, I tried to use a new adapter but that required more work, so I decided to update the existing one.
Test Plan
I added new tests to avoid possible regressions. Once merged, I will send a PR to the website to fix everything.