-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint/useAriaPropsSupportedByRole): add rule #3644
feat(lint/useAriaPropsSupportedByRole): add rule #3644
Conversation
CodSpeed Performance ReportMerging #3644 will not alter performanceComparing Summary
|
crates/biome_js_analyze/src/lint/nursery/use_aria_props_supported_by_role.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Victorien Elvinger <victorien@elvinger.fr>
@Conaclos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for your contribution, and sorry for the delay!
No Problem, thanks for review & merge! |
Summary
Enforce that ARIA properties are valid for the roles that are supported by the element.
Porting eslint-plugin-jsx-a11y/role-supports-aria-props rule
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/role-supports-aria-props.md
Issue:
Close #2613
Test Plan
eslint-plugin-jsx-a11y's test cases covered.
And several deprecated elements have been removed from the test cases.
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/role-supports-aria-props-test.js