Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js_semantic): use u32 for scope id #3358

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jul 5, 2024

Summary

This is a minor refactor to use u32 instead of usize for scope identification.

Test Plan

CI must pass.

@github-actions github-actions bot added the L-JavaScript Language: JavaScript and super languages label Jul 5, 2024
@Conaclos Conaclos changed the title refactor: use u32 for scope id representation refactor(js_semantic): use u32 for scope id representation Jul 5, 2024
@Conaclos Conaclos changed the title refactor(js_semantic): use u32 for scope id representation refactor(js_semantic): use u32 for scope id Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48223 48223 0
Passed 47026 47026 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6538 6538 0
Passed 2149 2149 0
Failed 4389 4389 0
Panics 0 0 0
Coverage 32.87% 32.87% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18250 18250 0
Passed 13987 13987 0
Failed 4263 4263 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

@Conaclos Conaclos force-pushed the conaclos/js_semantic_scope_id_u32 branch from d0ea0c2 to 3544a3b Compare July 5, 2024 15:22
@Conaclos Conaclos merged commit 3c23f59 into main Jul 5, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/js_semantic_scope_id_u32 branch July 5, 2024 16:47
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant