Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(noEmptyInterface): ignore empty interfaces in ambient modules #3116

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jun 7, 2024

Summary

Fix #3110

We now accept empty interfaces in global declarations declare global {} and ambient modules declare module "mod" {}.

Test Plan

I added tests.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jun 7, 2024
@Conaclos Conaclos force-pushed the conaclos/noEmptyInterface-ignore-in-ambient-modules branch from 3a958f6 to b91f941 Compare June 7, 2024 15:38
@Conaclos Conaclos merged commit ae34a8a into main Jun 7, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/noEmptyInterface-ignore-in-ambient-modules branch June 7, 2024 15:49
Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #3116 will not alter performance

Comparing conaclos/noEmptyInterface-ignore-in-ambient-modules (b91f941) with main (15dc839)

Summary

✅ 92 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 noEmptyInterface may break global augmentation
1 participant