Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade prettier to v3 in website/playground #311

Merged
merged 1 commit into from
Sep 17, 2023
Merged

chore: upgrade prettier to v3 in website/playground #311

merged 1 commit into from
Sep 17, 2023

Conversation

DerTimonius
Copy link
Contributor

Summary

This PR will upgrade prettier to currently 3.0.3 and fix problems associated with the upgrade:

  • function is now async
  • using prettier.format instead of debug.printToDocString.formatted
  • add the pluginEstree plugin like mentioned in this prettier issue
  • @types/prettier has been removed, types are now part of prettier
  • type PrettierOptions had to be extracted to the types.ts file

Test Plan

I could not find any e2e Tests for the website/playground, maybe some should be added either with this PR or in a separate PR?
From clicking through the playground you can see that it's still behaving as expected

closes #302

@github-actions github-actions bot added the A-Website Area: website label Sep 17, 2023
@Conaclos Conaclos merged commit 0825bb9 into biomejs:main Sep 17, 2023
@Conaclos
Copy link
Member

Thanks! :)

I could not find any e2e Tests for the website/playground, maybe some should be added either with this PR or in a separate PR?

What do you propose?

@Conaclos Conaclos mentioned this pull request Sep 17, 2023
1 task
@DerTimonius
Copy link
Contributor Author

Playwright comes to mind, I have some experience writing e2e tests with it. Maybe it's an option to check if both the biome and prettier output are behaving as expected

@DerTimonius DerTimonius deleted the chore/upgrade-prettier-playground branch September 17, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Upgrade prettier version in the playground
2 participants