fix(lint/noRedeclare): don't panic on conditional types #2664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2659
This is a regression introduced by #2394.
This regression makes
noRedeclare
panics on every conditional types withinfer
bindings.noRedeclare
checks the node type of every scope.Prior to #2615, it was unlikely to retrieve the syntax node of a scope.
The semantic model builder missed many associations. I thought I added all missing associations in #2615.
However, I forgot a case: syntax node of the scope of a conditional true type.
This led to #2394.
Test Plan
I added a test.