Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): fix JSON schema for stable hook options #2401

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Apr 10, 2024

Summary

Derived schema wasn't correct for enum, so I made a manual implementation.

Fixes #2396

Test Plan

Manually tested.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 9429b63
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6616c313f3eccb0008d0acfc
😎 Deploy Preview https://deploy-preview-2401--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 10 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Website Area: website A-Changelog Area: changelog labels Apr 10, 2024
@arendjr arendjr merged commit b9f716d into biomejs:main Apr 10, 2024
15 of 16 checks passed
Copy link

codspeed-hq bot commented Apr 10, 2024

CodSpeed Performance Report

Merging #2401 will degrade performances by 17.28%

Comparing arendjr:update-exhaustive-hooks-schema (9429b63) with main (39139a5)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main arendjr:update-exhaustive-hooks-schema Change
db.json[cached] 71.3 ms 67.1 ms +6.19%
eucjp.json[cached] 4.1 ms 4.9 ms -17.28%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 useExhaustiveDependencies' option hooks config schema is incorrect
1 participant