chore: derive Copy
on LoggingKind
and LoggingLevel
#2207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deriving
Copy
makes it so that types can be copied without needing to explicitly call.clone()
. This makes the type a little easier to work with, and also indicates there is no hidden performance cost to copying it. As such, it should only be derived on types that don't require allocations. For enums where the variants have no custom fields, derivingCopy
is generally safe, as long as no future variants with custom fields are anticipated either.See also: https://doc.rust-lang.org/std/marker/trait.Copy.html#when-should-my-type-be-copy
Test Plan
CI should remain green.