feat: css linter docs #2151
feat: css linter docs #2151
Conversation
github-actions
bot
added
A-Project
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I found that the CSS nursery lint rules are mixed in with the JS nursery:( Ideally, they should be separated, but I'm not sure how to do that yet, so I plan to look into it.
|
CodSpeed Performance ReportMerging #2151 will not alter performanceComparing Summary
|
|
Yeah, it's the same for JSON lint rules. Ideally, we should add new icons to that table. We could put a small JS icon or CSS icon next to the name of the rule |
justfile
Outdated
| # TODO: lintdoc, website, cargo doc | ||
| cargo run -p xtask_codegen -- new-lintrule --kind=css --name={{rulename}} | ||
| just gen-lint | ||
| just documentation |
There was a problem hiding this comment.
just documentation runs the lintdoc job - which is run by gen-lint - and it checks the cargo docs. I don't think we need to run the cargo docs
I like this idea since the logic to generate categories and groups is a bit complicated :P |
|
@ematipico I gave it a try. What do you think? |
|
Love it! |
togami2864
force-pushed
the
feat/csslint-doc
branch
from
c6ce1ab to
58e5093
Compare
togami2864
force-pushed
the
feat/csslint-doc
branch
from
58e5093 to
caca5f4
Compare
crates/biome_analyze/src/rule.rs
Outdated
| #[derive(Debug, Default, Clone)] | ||
| pub enum LanguageKind { | ||
| #[default] | ||
| Js, | ||
| Json, | ||
| Css, | ||
| } |
There was a problem hiding this comment.
Is there any chance that we can avoid adding language metadata inside the generic crate?
There was a problem hiding this comment.
I tried a bit, but it seems difficult for now. Each 'registry' will be visited, and rules will be stored in a BTreeMap, but since the visitor consolidates each nursery rules into one 'nursery', it becomes impossible to know the target language of those rules.
There was a problem hiding this comment.
I see. Can we revert the change for now? I need some time to think about it
togami2864
force-pushed
the
feat/csslint-doc
branch
from
a906118 to
5703e8d
Compare
Summary
lintdocandwebsitefor css linter.Test Plan
CI should be passed