fix(overrides): json.formatter.trailingCommas should work
#2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Respect `json.formatter.trailingCommas` option in `overrides` - Rename internal `trailing_comma`-named json-related vars to `trailing_commas` for consistency - Fix several discrepancies with reference to how `javascript.formatter.trailingComma` is handled
github-actions
bot
added
A-CLI
✅ Deploy Preview for biomejs canceled.
|
CodSpeed Performance ReportMerging #2025 will degrade performances by 6.09%Falling back to comparing Summary
Benchmarks breakdown
|
ematipico
approved these changes
Mar 9, 2024
| @@ -71,7 +71,7 @@ pub struct JsonFormatter { | |||
|
|
|||
| /// Print trailing commas wherever possible in multi-line comma-separated syntactic structures. Defaults to "none". | |||
| #[partial(bpaf(long("json-formatter-trailing-commas"), argument("none|all"), optional))] | |||
| pub trailing_commas: Option<TrailingCommas>, | |||
There was a problem hiding this comment.
I would like to keep this consistent with the rest of the CLI options.
There was a problem hiding this comment.
I reverted them in c0d3ab2.
There're some failures in CI tests, I'll take a look at them tomorrow.
1 task
|
still doesn't work |
|
@flazouh I think your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
json.formatter.trailingCommasoption inoverridestrailing_comma-named json-related vars totrailing_commasfor consistencyFixes #2009
Test Plan
Several tests are added in
crates/biome_cli/tests/commands/format.rsto show thatjson.formatter.trailingCommasworks inoverrides.