feat(biome_js_analyze): noExclusiveTests #1965
Conversation
github-actions
bot
added
A-Project
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #1965 will improve performances by 19.43%Falling back to comparing Summary
Benchmarks breakdown
|
chansuke
force-pushed
the
feat/no-exclusive-tets
branch
from
45f6c05 to
8b92265
Compare
chansuke
force-pushed
the
feat/no-exclusive-tets
branch
from
8b92265 to
835e2bf
Compare
| const CALEE_NAMES: [&str; 3] = ["describe", "it", "test"]; | ||
|
|
||
| impl Rule for NoExclusiveTests { | ||
| type Query = Ast<JsCallExpression>; |
There was a problem hiding this comment.
I think this rule should be in crates/biome_js_analyze/src/analyzers/nursery since you use the Ast, not Semantic.
https://github.com/biomejs/biome/blob/main/crates/biome_analyze/CONTRIBUTING.md?rgh-link-date=2023-08-23T12%3A52%3A31Z#:~:text=type%20Query%20%3D%20Ast%3C%3E%20%2D%3E%20analyzers/%20folder
| version: "next", | ||
| name: "noExclusiveTests", | ||
| recommended: true, | ||
| source: RuleSource::EslintJest("no-exclusive-tests"), |
There was a problem hiding this comment.
no-exclusive-test doesn't exist in eslint-plugin-jest. It's the rule of the eslint-plugin-mocha.
| describe.only("bar", function () {}); | ||
| it.only("bar", function () {}); | ||
| test.only("bar", function () {}); | ||
|
|
||
| describe.only("bar", () => {}); | ||
| it.only("bar", () => {}); | ||
| test.only("bar", () => {}); | ||
|
|
||
| describe["only"]("bar", function () {}); | ||
| it["only"]("bar", function () {}); | ||
| test["only"]("bar", function () {}); |
There was a problem hiding this comment.
I think we should also handle fdescribe, fit and ftest.
There was a problem hiding this comment.
@togami2864
Thank you for your review!! I will address feedbacks!
|
Yes...I will update the existing implementation(noFocusedTests).
|
Yes :) |
|
@Conaclos |
|
I've created new PR #1999 |
Summary
Fixes #597
Test Plan