feat(lint): rule noMisplacedAssertion

[ematipico]

Summary

This PR closes #1848 (last rule)

It implements the rule noMisplacedAssertion, which checks if expect or assert are called inside the it function.

This rule has options: users can define the name of the assertion functions and the specifiers from which these functions are imported.

Test Plan

Added test cases

[netlify]

✅ Deploy Preview for biomejs ready!

Name	Link
🔨 Latest commit	7caeea7
🔍 Latest deploy log	https://app.netlify.com/sites/biomejs/deploys/660421de5ed1b20008043dcf
😎 Deploy Preview	https://deploy-preview-1935--biomejs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🔴 down 1 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Parser conformance results on

js/262

Test result	main count	This PR count	Difference
Total	49701	49701	0
Passed	48721	48721	0
Failed	980	980	0
Panics	0	0	0
Coverage	98.03%	98.03%	0.00%

jsx/babel

Test result	main count	This PR count	Difference
Total	40	40	0
Passed	37	37	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.50%	92.50%	0.00%

symbols/microsoft

Test result	main count	This PR count	Difference
Total	6322	6322	0
Passed	2036	2036	0
Failed	4286	4286	0
Panics	0	0	0
Coverage	32.20%	32.20%	0.00%

ts/babel

Test result	main count	This PR count	Difference
Total	662	662	0
Passed	593	593	0
Failed	69	69	0
Panics	0	0	0
Coverage	89.58%	89.58%	0.00%

ts/microsoft

Test result	main count	This PR count	Difference
Total	17646	17646	0
Passed	13439	13439	0
Failed	4205	4205	0
Panics	2	2	0
Coverage	76.16%	76.16%	0.00%

[codspeed-hq]

CodSpeed Performance Report

Merging #1935 will not alter performance

_{Comparing feat/no-misplaced-assertion (7caeea7) with main (ad0a0b5)}

Summary

✅ 93 untouched benchmarks

[arendjr]

I like this rule, but I think it's a bit too opinionated towards the describe/it pattern. At the least I would let it support the test function (and ideally also Deno.test) by default as well, like these:

• https://jestjs.io/docs/api#testname-fn-timeout
• https://docs.deno.com/runtime/manual/basics/testing/

And then we can probably add the bun:test specifier too :)

• https://bun.sh/docs/cli/test#run-tests

[ematipico]

I refactored the rule. I removed the options - for now. Let's see what the users say and devise a plan when the time comes.

Now the built-in assertions are wider, for example bun, vitest and Deno.test are taken in consideration.

[arendjr]

Very nice!

[ipanasenko]

What about waitFor from testing-library? Their official docs recommend to use expect inside waitFor to wait for something: https://testing-library.com/docs/dom-testing-library/api-async#waitfor

[ipanasenko]

And maybe allow to use expect() inside other functions that start with expect? E.g. a common const expectSomeStuffToMatch = (stuff) => expect(stuff).toMatch()

[ematipico]

Hey @ipanasenko, thank you for your suggestions. I advise you to create a discussion, a thread on discord or a new issue. Commenting on closed PRs doesn't help the visibility of your suggestions.