feat(lint/noConfusingVoidType): add no-confusing-void-type #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Core
shulandmimi
changed the title
Conaclos
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Thanks for your contribution! :)
I just have two main concerns:
- New rule should be part of the nursery group (see the CONTRIBUTING guide for more details).
- I suggest also removing the options because Biome tries to minimize them. Because these patterns are widely sued we should assume that these options are always set to true.
crates/rome_js_analyze/src/analyzers/complexity/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
…stead of cast_ref
shulandmimi
force-pushed
the
feat/noConfusingVoidType
branch
from
f7db11e to
4b972b0
Compare
Conaclos
reviewed
Sep 8, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_confusing_void_type.rs
Outdated
Show resolved
Hide resolved
shulandmimi
force-pushed
the
feat/noConfusingVoidType
branch
from
997230e to
60b6e96
Compare
Conaclos
approved these changes
Sep 8, 2023
|
@Conaclos Thank you for reviewing and helping me |
|
This is a great contribution! |
Conaclos
added
S-Needs-changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #45
This rule implements some part of no-invalid-void-type
Test Plan
Tests included.