refactor(js_syntax): use dedicated declarations for binding patterns

[Conaclos]

Summary

Fix #1648
Fix #1652.

Previously, Biome returned the parent declaration for any binding patterns.
For instance:

const { a, b = a } = {};
      ^^^^^^^^^^^^
      declaration of both `a` and `b`
export { b }

Because rules such as noInvalidUseBeforeDeclaration and noUnusedVariables rely on the actual declarations, this resulted in wrong false positive or wrong false negative: in the previous example, a is wrongly reported as unused and its use is wrongly reported as a use before declaration.

Now, a and b have distinct and dedicated declarations:

const { a, b = a } = {};
        ^  ^^^^^
        |  declaration of `b`
        declaration of `a`
export { b }

This avoids the two previous issues.

I had to replace JsBindingWithDefault by JsArrayBindingPatternElement in order to get a proper type for the declaration of an array pattern element. This makes also the CST more consistent, because is analog to JsObjectBindingPatternShorthandProperty and JsObjectBindingPatternProperty and it reuses JsInitializerClause.
For consistency, I also replaced JsAssignementWithDefault by JsArrayAssignementPatternElement

• The first commit change the grammar.
• The second one modifies how we resolve declarations of binding element.
• The third commit adds tests to avoid regression for 💅 noInvalidUseBeforeDeclaration - false-positive for param destructuring with default values #1648 and 💅 noUnusedVariables - false-positive for param destructuring if it's used as a default value for another destructured param #1652.

Remaining tasks:

• add changelog entries

Test Plan

• New tests added.

[netlify]

✅ Deploy Preview for biomejs canceled.

Name	Link
🔨 Latest commit	54d4bb0
🔍 Latest deploy log	https://app.netlify.com/sites/biomejs/deploys/65cb6751f4a06e00086ffbb3

[github-actions]

Parser conformance results on

js/262

Test result	main count	This PR count	Difference
Total	49701	49701	0
Passed	48721	48721	0
Failed	980	980	0
Panics	0	0	0
Coverage	98.03%	98.03%	0.00%

jsx/babel

Test result	main count	This PR count	Difference
Total	40	40	0
Passed	37	37	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.50%	92.50%	0.00%

symbols/microsoft

Test result	main count	This PR count	Difference
Total	6322	6322	0
Passed	2036	2036	0
Failed	4286	4286	0
Panics	0	0	0
Coverage	32.20%	32.20%	0.00%

ts/babel

Test result	main count	This PR count	Difference
Total	662	662	0
Passed	593	593	0
Failed	69	69	0
Panics	0	0	0
Coverage	89.58%	89.58%	0.00%

ts/microsoft

Test result	main count	This PR count	Difference
Total	17646	17646	0
Passed	13439	13439	0
Failed	4205	4205	0
Panics	2	2	0
Coverage	76.16%	76.16%	0.00%

[codspeed-hq]

CodSpeed Performance Report

Merging #1800 will not alter performance

_{Comparing conaclos/declaration-fixes (54d4bb0) with main (dca6a7a)}

Summary

✅ 93 untouched benchmarks

[arendjr]

Haven’t looked at all the code changes, but appreciate the clear explanation. Sounds like a good solution 👍