Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css-parser): CSS Parser: parse starting-style at rule #1478 #1518

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

denbezrukov
Copy link
Contributor

Summary

Close #1478

https://drafts.csswg.org/css-transitions-2/#at-ruledef-starting-style

@starting-style {
    rulesets
  }

selector {
 @starting-style {
   declarations
 }
}

Test Plan

cargo test

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit bed0aa1
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/659f0b3e82bbd30008d55f82

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS labels Jan 10, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13452 13452 0
Failed 4192 4192 0
Panics 2 2 0
Coverage 76.23% 76.23% 0.00%

Copy link

codspeed-hq bot commented Jan 10, 2024

CodSpeed Performance Report

Merging #1518 will not alter performance

⚠️ No base runs were found

Falling back to comparing feat/css-starting-style (bed0aa1) with main (352b87d)

Summary

✅ 93 untouched benchmarks

@denbezrukov denbezrukov merged commit 2cd6eaf into main Jan 11, 2024
@denbezrukov denbezrukov deleted the feat/css-starting-style branch January 11, 2024 21:16
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Parser: parse starting-style at rule
2 participants