Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint/noConsoleLog): add code action #1497

Merged
merged 30 commits into from
Jan 10, 2024

Conversation

vasucp1207
Copy link
Member

@vasucp1207 vasucp1207 commented Jan 9, 2024

Summary

noConsoleLog code action

Test Plan

No new test cases

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 34856f4
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/659dbf13b463c600098b866c
😎 Deploy Preview https://deploy-preview-1497--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Jan 9, 2024
@vasucp1207 vasucp1207 changed the title Console log action refactor: noConsoleLog code action Jan 9, 2024
Copy link

codspeed-hq bot commented Jan 9, 2024

CodSpeed Performance Report

Merging #1497 will not alter performance

Comparing vasucp1207:consoleLogAction (34856f4) with main (6473a2e)

Summary

✅ 93 untouched benchmarks

@Conaclos Conaclos changed the title refactor: noConsoleLog code action refactor(lint/noConsoleLog): add code action Jan 9, 2024
@Conaclos
Copy link
Member

Conaclos commented Jan 9, 2024

Could you add a changelog entry in an Enhancements subsection (placed just before the subsection Bug fixes) under the section linter?

@github-actions github-actions bot added the A-Changelog Area: changelog label Jan 9, 2024
@Conaclos
Copy link
Member

Conaclos commented Jan 9, 2024

I will delay the merge until we release a patch version.

@Conaclos Conaclos merged commit 352b87d into biomejs:main Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants