📎 Small refactor for the test infrastructure of biome_cli

[ematipico]

Description

I recently created a small utility:

biome/crates/biome_cli/tests/snap_test.rs

Lines 357 to 370 in 52dae46

	pub fn assert_file_contents(fs: &MemoryFileSystem, path: &Path, expected_content: &str) {
	let mut file = fs.open(path).expect("file was removed");
	let mut content = String::new();
	file.read_to_string(&mut content)
	.expect("failed to read file from memory FS");
	assert_eq!(
	content,
	expected_content,
	"file {} doesn't match the expected content",
	path.display()
	);
	}

This utility is used to make assertions around file contents easier and less code repetition.

The task is to replace code like this:

biome/crates/biome_cli/tests/commands/format.rs

Lines 135 to 145 in 52dae46

	let mut file = fs
	.open(file_path)
	.expect("formatting target file was removed by the CLI");
	let mut content = String::new();
	file.read_to_string(&mut content)
	.expect("failed to read file from memory FS");
	assert_eq!(content, UNFORMATTED);
	drop(file);

And replace it with the usage of the utility.

If/when working on it, search for drop( inside the tests, and that's where you want to do the substitution.

All tests must pass, and all snapshots must stay the same. If anything changes, something went wrong.

[msdlisper]

It does reduce a lot of boilerplate code, can I try to accomplish this task?

[Conaclos]

@msdlisper You are welcome :)

[msdlisper]

@Conaclos Could you check the code for me? :)