fix(lint/noStaticOnlyClass): prevent error on static classes that ext…

…end other classes (#3626)
biomejs · Aug 16, 2024 · ffb66d9 · ffb66d9
1 parent 8b4f3ff
commit ffb66d9
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 1 deletion.
diff --git a/crates/biome_js_analyze/src/lint/complexity/no_static_only_class.rs b/crates/biome_js_analyze/src/lint/complexity/no_static_only_class.rs
@@ -149,6 +149,10 @@ impl Rule for NoStaticOnlyClass {
             return None;
         }
 
+        if class_declaration.extends_clause().is_some() {
+            return None;
+        }
+
         let all_members_static = class_declaration
             .members()
             .iter()

diff --git a/crates/biome_js_analyze/tests/specs/complexity/noStaticOnlyClass/valid.ts b/crates/biome_js_analyze/tests/specs/complexity/noStaticOnlyClass/valid.ts
@@ -66,3 +66,32 @@ class StaticConstants1 {
 }
 
 class Empty {}
+
+class Environment {
+	type: string;
+
+	constructor(type: string) {
+		this.type = type;
+	}
+
+	getType(): string {
+		return this.type;
+	}
+}
+
+class Application extends Environment {
+	private static environment: Environment;
+
+	static initialize(type: string): void {
+		if (!this.environment) {
+			this.environment = new Environment(type);
+		}
+	}
+
+	static getEnvironment(): string {
+		if (!this.environment) {
+			throw new Error("Application not initialized.");
+		}
+		return this.environment.getType();
+	}
+}
diff --git a/crates/biome_js_analyze/tests/specs/complexity/noStaticOnlyClass/valid.ts.snap b/crates/biome_js_analyze/tests/specs/complexity/noStaticOnlyClass/valid.ts.snap
@@ -73,6 +73,33 @@ class StaticConstants1 {
 
 class Empty {}
 
-```
+class Environment {
+	type: string;
+
+	constructor(type: string) {
+		this.type = type;
+	}
+
+	getType(): string {
+		return this.type;
+	}
+}
 
+class Application extends Environment {
+	private static environment: Environment;
 
+	static initialize(type: string): void {
+		if (!this.environment) {
+			this.environment = new Environment(type);
+		}
+	}
+
+	static getEnvironment(): string {
+		if (!this.environment) {
+			throw new Error("Application not initialized.");
+		}
+		return this.environment.getType();
+	}
+}
+
+```