feat(lint/useDefaultSwitchClause): treat empty switch statements as i…

…nvalid

crates/biome_js_analyze/src/lint/nursery/use_default_switch_clause.rs

@@ -37,11 +37,6 @@ declare_rule! {
     ///         break;
     /// }
     /// ```
-    ///
-    /// ```js
-    /// switch (a) {
-    /// }
-    /// ```
     pub UseDefaultSwitchClause {
         version: "next",
         name: "useDefaultSwitchClause",
@@ -59,16 +54,13 @@ impl Rule for UseDefaultSwitchClause {
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
         let node = ctx.query();
 
-        let has_case_clauses = node.cases().into_iter().len() > 0;
         let is_missing_default_case = node
             .cases()
             .into_iter()
             .any(|clause| clause.as_js_default_clause().is_some())
             .not();
 
-        let is_valid = is_missing_default_case && has_case_clauses;
-
-        is_valid.then_some(())
+        is_missing_default_case.then_some(())
     }
 
     fn diagnostic(ctx: &RuleContext<Self>, _state: &Self::State) -> Option<RuleDiagnostic> {

crates/biome_js_analyze/tests/specs/nursery/useDefaultSwitchClause/invalid.js

@@ -2,3 +2,6 @@ switch (a) {
 	case 1:
 		break;
 }
+
+switch (a) {
+}

crates/biome_js_analyze/tests/specs/nursery/useDefaultSwitchClause/invalid.js.snap

@@ -9,6 +9,9 @@ switch (a) {
 		break;
 }
 
+switch (a) {
+}
+
 ```
 
 # Diagnostics
@@ -24,6 +27,27 @@ invalid.js:1:1 lint/nursery/useDefaultSwitchClause ━━━━━━━━━
   > 4 │ }
       │ ^
     5 │ 
+    6 │ switch (a) {
+  
+  i The lack of a default clause can be a possible omission.
+  
+  i Consider adding a default clause.
+  
+
+```
+
+```
+invalid.js:6:1 lint/nursery/useDefaultSwitchClause ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Expected a default switch clause.
+  
+    4 │ }
+    5 │ 
+  > 6 │ switch (a) {
+      │ ^^^^^^^^^^^^
+  > 7 │ }
+      │ ^
+    8 │ 
   
   i The lack of a default clause can be a possible omission.
   

crates/biome_js_analyze/tests/specs/nursery/useDefaultSwitchClause/valid.js

@@ -12,6 +12,3 @@ switch (a) {
 	default:
 		break;
 }
-
-switch (a) {
-}

crates/biome_js_analyze/tests/specs/nursery/useDefaultSwitchClause/valid.js.snap

@@ -19,7 +19,4 @@ switch (a) {
 		break;
 }
 
-switch (a) {
-}
-
 ```