fix(lint_rules): false positives of several rules (#2278)

CHANGELOG.md

@@ -39,6 +39,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 ### Linter
 
+#### Bug fixes
+
+- Lint rules `useNodejsImportProtocol`, `useNodeAssertStrict`, `noRestrictedImports`, `noNodejsModules` will no longer check `declare module` statements anymore. Contributed by @Sec-ant
+
 #### New features
 
 #### Enhancements

crates/biome_js_analyze/src/lint/nursery/no_nodejs_modules.rs

@@ -41,7 +41,11 @@ impl Rule for NoNodejsModules {
     type Options = ();
 
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
-        let module_name = ctx.query().module_name_token()?;
+        let node = ctx.query();
+        if node.is_in_ts_module_declaration() {
+            return None;
+        }
+        let module_name = node.module_name_token()?;
         is_node_builtin_module(&inner_string_text(&module_name))
             .then_some(module_name.text_trimmed_range())
     }

crates/biome_js_analyze/src/lint/nursery/no_restricted_imports.rs

@@ -49,7 +49,11 @@ impl Rule for NoRestrictedImports {
     type Options = Box<RestrictedImportsOptions>;
 
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
-        let module_name = ctx.query().module_name_token()?;
+        let node = ctx.query();
+        if node.is_in_ts_module_declaration() {
+            return None;
+        }
+        let module_name = node.module_name_token()?;
         let inner_text = inner_string_text(&module_name);
 
         ctx.options()

crates/biome_js_analyze/src/lint/nursery/no_undeclared_dependencies.rs

@@ -1,8 +1,8 @@
 use crate::services::manifest::Manifest;
 use biome_analyze::{context::RuleContext, declare_rule, Rule, RuleDiagnostic};
 use biome_console::markup;
-use biome_js_syntax::{AnyJsImportSpecifierLike, TsExternalModuleDeclaration};
-use biome_rowan::{AstNode, SyntaxNodeOptionExt};
+use biome_js_syntax::AnyJsImportSpecifierLike;
+use biome_rowan::AstNode;
 
 declare_rule! {
     /// Disallow the use of dependencies that aren't specified in the `package.json`.
@@ -44,13 +44,8 @@ impl Rule for NoUndeclaredDependencies {
 
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
         let node = ctx.query();
-
-        if let Some(parent_syntax_kind) = node.syntax().parent().kind() {
-            // Ignore module declaration statements:
-            // declare module "jest";
-            if TsExternalModuleDeclaration::can_cast(parent_syntax_kind) {
-                return None;
-            }
+        if node.is_in_ts_module_declaration() {
+            return None;
         }
 
         let token_text = node.inner_string_text()?;

crates/biome_js_analyze/src/lint/nursery/use_node_assert_strict.rs

@@ -42,12 +42,13 @@ impl Rule for UseNodeAssertStrict {
 
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
         let node = ctx.query();
-
-        let text = node.module_name_token()?;
-        if inner_string_text(&text) == "node:assert" {
-            return Some(text);
+        if node.is_in_ts_module_declaration() {
+            return None;
+        }
+        let module_name = node.module_name_token()?;
+        if inner_string_text(&module_name) == "node:assert" {
+            return Some(module_name);
         }
-
         None
     }
 

crates/biome_js_analyze/src/lint/style/use_nodejs_import_protocol.rs

@@ -57,7 +57,11 @@ impl Rule for UseNodejsImportProtocol {
     type Options = ();
 
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
-        let module_name = ctx.query().module_name_token()?;
+        let node = ctx.query();
+        if node.is_in_ts_module_declaration() {
+            return None;
+        }
+        let module_name = node.module_name_token()?;
         is_node_module_without_protocol(&inner_string_text(&module_name)).then_some(module_name)
     }
 

crates/biome_js_analyze/tests/specs/nursery/noNodejsModules/valid.ts

@@ -0,0 +1 @@
+declare module "node:fs" {}

crates/biome_js_analyze/tests/specs/nursery/noNodejsModules/valid.ts.snap

@@ -0,0 +1,8 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: valid.ts
+---
+# Input
+```ts
+declare module "node:fs" {}
+```

crates/biome_js_analyze/tests/specs/nursery/noRestrictedImports/valid.options.json

@@ -6,7 +6,9 @@
 				"noRestrictedImports": {
 					"level": "error",
 					"options": {
-						"paths": {}
+						"paths": {
+							"node:fs": "Importing from node:fs is forbidden"
+						}
 					}
 				}
 			}

crates/biome_js_analyze/tests/specs/nursery/noRestrictedImports/valid.ts

@@ -0,0 +1 @@
+declare module "node:fs" {}

crates/biome_js_analyze/tests/specs/nursery/noRestrictedImports/valid.ts.snap

@@ -0,0 +1,8 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: valid.ts
+---
+# Input
+```ts
+declare module "node:fs" {}
+```

crates/biome_js_analyze/tests/specs/nursery/useNodeAssertStrict/valid.ts

@@ -0,0 +1 @@
+declare module "node:assert" {}

crates/biome_js_analyze/tests/specs/nursery/useNodeAssertStrict/valid.ts.snap

@@ -0,0 +1,8 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: valid.ts
+---
+# Input
+```ts
+declare module "node:assert" {}
+```

crates/biome_js_analyze/tests/specs/style/useNodejsImportProtocol/valid.ts

@@ -0,0 +1 @@
+declare module "module" {}

crates/biome_js_analyze/tests/specs/style/useNodejsImportProtocol/valid.ts.snap

@@ -0,0 +1,8 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: valid.ts
+---
+# Input
+```ts
+declare module "module" {}
+```

crates/biome_js_syntax/src/import_ext.rs

@@ -1,9 +1,9 @@
 use crate::{
     inner_string_text, AnyJsBinding, AnyJsImportClause, AnyJsNamedImportSpecifier,
     JsCallExpression, JsImport, JsImportAssertion, JsImportCallExpression, JsModuleSource,
-    JsSyntaxToken,
+    JsSyntaxToken, TsExternalModuleDeclaration,
 };
-use biome_rowan::{declare_node_union, AstNode, SyntaxResult, TokenText};
+use biome_rowan::{declare_node_union, AstNode, SyntaxNodeOptionExt, SyntaxResult, TokenText};
 
 impl JsImport {
     /// It checks if the source of an import against the string `source_to_check`
@@ -303,4 +303,37 @@ impl AnyJsImportSpecifierLike {
             }
         }
     }
+
+    /// Check whether the js import specifier like is in a ts module declaration:
+    /// ```ts
+    /// declare "abc" {}
+    /// ```
+    /// ## Examples
+    ///
+    /// ```
+    /// use biome_js_factory::make;
+    /// use biome_js_syntax::{AnyJsImportSpecifierLike, JsSyntaxKind, JsSyntaxToken};
+    /// use biome_rowan::TriviaPieceKind;
+    ///
+    /// let module_token = JsSyntaxToken::new_detached(JsSyntaxKind::MODULE_KW, "module", [], []);
+    /// let module_source = make::js_module_source(make::js_string_literal("foo"));
+    /// let module_declaration = make::ts_external_module_declaration(module_token, module_source).build();
+    /// let any_import_specifier = AnyJsImportSpecifierLike::JsModuleSource(module_declaration.source().expect("module source"));
+    /// assert!(any_import_specifier.is_in_ts_module_declaration());
+    ///
+    /// let module_source = make::js_module_source(make::js_string_literal("bar"));
+    /// let any_import_specifier = AnyJsImportSpecifierLike::JsModuleSource(module_source);
+    /// assert!(!any_import_specifier.is_in_ts_module_declaration());
+    /// ```
+    pub fn is_in_ts_module_declaration(&self) -> bool {
+        // It first has to be a JsModuleSource
+        if !matches!(self, AnyJsImportSpecifierLike::JsModuleSource(_)) {
+            return false;
+        }
+        // Then test whether its parent is a TsExternalModuleDeclaration
+        if let Some(parent_syntax_kind) = self.syntax().parent().kind() {
+            return TsExternalModuleDeclaration::can_cast(parent_syntax_kind);
+        }
+        false
+    }
 }

website/src/content/docs/internals/changelog.md

@@ -45,6 +45,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 ### Linter
 
+#### Bug fixes
+
+- Lint rules `useNodejsImportProtocol`, `useNodeAssertStrict`, `noRestrictedImports`, `noNodejsModules` will no longer check `declare module` statements anymore. Contributed by @Sec-ant
+
 #### New features
 
 #### Enhancements