feature/require minimum bioio-base for plugins #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianWhitneyAI
approved these changes
Jul 13, 2023
toloudis
reviewed
Jul 13, 2023
| ) | ||
| < 0 | ||
| ): | ||
| print( |
There was a problem hiding this comment.
at some point these prints should maybe be logs instead; not necessarily for this pr
toloudis
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
This pull request resolves #2 where I requested plugins meet a minimum
bioio-typesversion.Description of Changes
The search for plugins will now check the listed version specifications for this distribution (
bioio) against each plugin ensuring that the listed minimum forbioiois <= the maximum listed for the plugin.Testing
No plugin has a minimum
bioio-typesyet, but I tested against other dependencies likedocutilswhere it seems to perform as expected.