Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct package name for bioio-base #19

Merged
merged 3 commits into from
Nov 3, 2023
Merged

use correct package name for bioio-base #19

merged 3 commits into from
Nov 3, 2023

Conversation

toloudis
Copy link
Contributor

@toloudis toloudis commented Nov 2, 2023

I think we can't really use bioio without this change. This is required for get_plugins to work, and get_plugins is currently reqiured in order to have any file format support.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
bioio/plugins.py Outdated
@@ -22,7 +22,7 @@
###############################################################################

BIOIO_DIST_NAME = "bioio"
BIOIO_BASE_DIST_NAME = "bioio-types" # TODO: Rename to bioio-base
BIOIO_BASE_DIST_NAME = "bioio-base" # TODO: Rename to bioio-base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the TODO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@toloudis toloudis merged commit 4733c3d into main Nov 3, 2023
@toloudis toloudis deleted the toloudis-patch-1 branch November 3, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants