-
Notifications
You must be signed in to change notification settings - Fork 37
Adding new format to upload annotations in source: CSV #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. just a couple of optional nits.
bigmler/processing/annotations.py
Outdated
if regions != "": | ||
annotations[filename] = [] | ||
boxes = [] | ||
regions = regions.replace(REGION_FIELD_SEPARATOR, "],[") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a nit, but since we're defining a constant for the field separator, perhaps the replacement, "],[" should also be one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right
In whizzml, `][`, `] [`, `] [`, are equivalent, valid syntax...
|
But regions are formatted using "] [" when the dataset CSV is formatted for download. |
ok, that's what i was asking, if this is only used for those CSVs then yes, there's no need to check anything else |
No description provided.