Skip to content

Adding new format to upload annotations in source: CSV #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 17, 2025
Merged

Adding new format to upload annotations in source: CSV #267

merged 10 commits into from
Jan 17, 2025

Conversation

mmerce
Copy link
Member

@mmerce mmerce commented Jan 14, 2025

No description provided.

@mmerce mmerce requested a review from jaor January 14, 2025 10:50
Copy link
Member

@jaor jaor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. just a couple of optional nits.

if regions != "":
annotations[filename] = []
boxes = []
regions = regions.replace(REGION_FIELD_SEPARATOR, "],[")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nit, but since we're defining a constant for the field separator, perhaps the replacement, "],[" should also be one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

@jaor
Copy link
Member

jaor commented Jan 14, 2025 via email

@mmerce
Copy link
Member Author

mmerce commented Jan 14, 2025

In whizzml, ][, ] [, ] [, are equivalent, valid syntax...

But regions are formatted using "] [" when the dataset CSV is formatted for download.

@jaor
Copy link
Member

jaor commented Jan 14, 2025

In whizzml, ][, ] [, ] [, are equivalent, valid syntax...

But regions are formatted using "] [" when the dataset CSV is formatted for download.

ok, that's what i was asking, if this is only used for those CSVs then yes, there's no need to check anything else

@jaor jaor merged commit f876bd4 into master Jan 17, 2025
7 checks passed
@jaor jaor deleted the dgc branch March 28, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants