Add AeroTherm2023 models #209
Conversation
|
@spahrenk is this ready to review again? |
|
Should be able to change the build folder now. |
src/HPWH.hh
Outdated
| @@ -282,7 +282,10 @@ class HPWH : public Courier::Sender | |||
|
|
|||
| MODELS_AquaThermAire = 400, // heat exchanger model | |||
|
|
|||
| MODELS_GenericUEF217 = 410 | |||
| MODELS_GenericUEF217 = 410, | |||
There was a problem hiding this comment.
This should probably be added to the other generic models (e.g., number 179).
src/HPWH.hh
Outdated
| MODELS_AeroTherm2023_50 = 411, | ||
| MODELS_AeroTherm2023_65 = 412, | ||
| MODELS_AeroTherm2023_80 = 413 |
There was a problem hiding this comment.
Start a new series (500?) for Bradford-White AeroTherm. Follow same naming convention as other enumerations:
MODELS_BradfordWhiteAeroThermRE2H50
|
Ready to review. |
There was a problem hiding this comment.
I'm still a bit confused by this file. It seems hard-coded to villara. Do we anticipate needing this file for future models? We talked with Ben about setting a standardized template for manufacturers to supply test data. Would that obsolete the need for this file?
There was a problem hiding this comment.
Two formats encountered to date are both implemented. No information on other formats may emerge.
There was a problem hiding this comment.
Similar with this file. Is there an example you can point to where this has been used?
There was a problem hiding this comment.
Used for all Aerotherm2023 models provided. Not intended as an automated tool for arbitrary format.
Bradford White Aerotherm2023 50-, 65-, and 80-gal models are incorporated into HPWHsim. The 50-gal model was refined to match reasonably the RE2H50_UEF50 and RE2H50_UEF67 test schedules extracted from the provided measured datasets. These schedules were translated into the standard HPWHsim, multifile, schedule format, using scripts added to scripts/conversion.
Additional python scripts and an html file were added to facilitate comparison of simulated and measured profiles. The comparison is done by 1) running
poetry run python server.pyfrom within the scripts/python folder and 2) opening the fileindex.htmlfrom a browser (e.g., Chrome). The user can interactively specify the HPWH model and specification, then apply test parameters or view the 24-hr test output. Presently, a measured test data file (for comparison to simulated test data) must be specified to generate plots.