Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 compatibility #93

Merged
merged 1 commit into from
Jul 25, 2022
Merged

PHP8 compatibility #93

merged 1 commit into from
Jul 25, 2022

Conversation

noplanman
Copy link
Contributor

Description

Fixes #92 - Update to work correctly with PHP8

Change Log

  • wp.phpVersion also accepts a string, to explicitly define a version without truncation (i.e. "8.0" vs. 8)
  • WP Cypress plugin uses latest fakerphp/faker library

Types of changes:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

@noplanman
Copy link
Contributor Author

noplanman commented May 26, 2022 •
edited
Loading

P.S. I've noticed develop branch is behind master, so I'm targetting the updated master here.
develop should be updated though...

Or should I point towards release/1.0.0?

@noplanman noplanman mentioned this pull request May 26, 2022
Open
@ampersarnie ampersarnie changed the base branch from master to release/1.0.0 July 6, 2022 10:50
@ampersarnie ampersarnie added this to the v1.0.0 milestone Jul 6, 2022
@noplanman
Copy link
Contributor Author

@ampersarnie Anything else you'd like to see in this PR to get it merged?

PaulREnglish
PaulREnglish approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@PaulREnglish PaulREnglish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@ampersarnie ampersarnie merged commit 28550d2 into bigbite:release/1.0.0 Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulREnglish PaulREnglish PaulREnglish approved these changes

Assignees
No one assigned
Labels
priority:high
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Doesn't play nicely with PHP8
3 participants
@noplanman @PaulREnglish @ampersarnie