Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting and tests #85

Merged
merged 7 commits into from
Jan 21, 2022
Merged

Conversation

ampersarnie
Copy link
Member

@ampersarnie ampersarnie commented Jan 6, 2022

Description

To ensure that we're moving forward for v1.0.0 release and putting ourselves in a better position with subsequent releases, some changes have been required for formatting and general maintenance. Formatting now follows the prettier standard to ensure that formatting is consistent. Jest tests have been added for utilities - though not for all areas this gives us a good start. Huskey has been updated to allow for tests to be run on push as well as linting checks.

I have also removed the yarn.lock file to encourage more use of npm rather than yarn as a standard.

Change Log

  • Added prettier and corrected changes resulting from that.
  • Added jest tests for utilities.
  • Updated husky and config for v4 -> v7 changes.
  • Added test runs to husky pre-push.

Checklist (if applicable):

  • Meets provided linting standards.

@ampersarnie ampersarnie requested a review from con322 January 6, 2022 09:43
@con322
Copy link
Contributor

con322 commented Jan 11, 2022

Nice pr :)

I tried running the jest tests and a couple failed. The error looked to be the same for all of them see below.

screenshot

@ampersarnie
Copy link
Member Author

Nice pr :)

I tried running the jest tests and a couple failed. The error looked to be the same for all of them see below.

screenshot

Looks like Jest is catching the Cypress tests as well. I'll look into exclusion paths.

@ampersarnie
Copy link
Member Author

@con322 This should be fixed now if you would like to review again.

@ampersarnie ampersarnie mentioned this pull request Jan 19, 2022
@con322
Copy link
Contributor

con322 commented Jan 19, 2022

@ampersarnie failed tests have gone from 13 to 9 but some are still failing.

image

@ampersarnie
Copy link
Member Author

Spoke with Connor about the above, issues were differences in setup and Babel transforms on Node v12 providing false reports for coverage. Node v14 and v16 are known to work. Seen the issue also reported here; jestjs/jest#10740

@ampersarnie ampersarnie merged commit 85270e3 into bigbite:1.0.0 Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants