-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code formatting and tests #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@con322 This should be fixed now if you would like to review again. |
Closed
@ampersarnie failed tests have gone from 13 to 9 but some are still failing. |
con322
approved these changes
Jan 21, 2022
Spoke with Connor about the above, issues were differences in setup and Babel transforms on Node v12 providing false reports for coverage. Node v14 and v16 are known to work. Seen the issue also reported here; jestjs/jest#10740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To ensure that we're moving forward for
v1.0.0
release and putting ourselves in a better position with subsequent releases, some changes have been required for formatting and general maintenance. Formatting now follows the prettier standard to ensure that formatting is consistent. Jest tests have been added for utilities - though not for all areas this gives us a good start. Huskey has been updated to allow for tests to be run on push as well as linting checks.I have also removed the
yarn.lock
file to encourage more use ofnpm
rather thanyarn
as a standard.Change Log
prettier
and corrected changes resulting from that.jest
tests for utilities.husky
and config for v4 -> v7 changes.pre-push
.Checklist (if applicable):