pick nits from example bounding_2d #12563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwsmm
commented
Mar 19, 2024
Comment on lines
+287
to
+291
| fn draw_filled_circle(gizmos: &mut Gizmos, position: Vec2, color: Srgba) { | ||
| for r in [1., 2., 3.] { | ||
| gizmos.circle_2d(position, r, color); | ||
| } | ||
| } |
There was a problem hiding this comment.
Previously, this logic appeared in two places. I pulled it into a function with a name that explains what it's trying to do.
awwsmm
commented
Mar 19, 2024
Comment on lines
-353
to
+359
| aabb_cast.ray.ray.origin | ||
| + *aabb_cast.ray.ray.direction * toi | ||
| + aabb_cast.aabb.center(), | ||
| aabb_cast.ray.ray.origin + *aabb_cast.ray.ray.direction * toi, |
There was a problem hiding this comment.
aabb_cast.aabb.center() is always Vec2(0.0, 0.0), and so adding it here has no effect on the position of the rendered rect_2d
awwsmm
commented
Mar 19, 2024
Comment on lines
-384
to
+388
| circle_cast.ray.ray.origin | ||
| + *circle_cast.ray.ray.direction * toi | ||
| + circle_cast.circle.center(), | ||
| circle_cast.ray.ray.origin + *circle_cast.ray.ray.direction * toi, |
There was a problem hiding this comment.
ditto for this circle_2d
alice-i-cecile
approved these changes
Mar 19, 2024
alice-i-cecile
added
C-Examples
Jondolf
approved these changes
Mar 21, 2024
Jondolf
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Vec2(0.0, 0.0))