Merge pull request #49 from acrobat/usability-fixes

Usability fixes
bernardphp · Jul 10, 2017 · 24def49 · 24def49
2 parents dec3a0f + 25463c3
commit 24def49
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -25,7 +25,7 @@ public function getConfigTreeBuilder()
                     ->addDefaultsIfNotSet()
                     ->children()
                         ->scalarNode('connection')->defaultValue('default')->end()
-                        ->scalarNode('directory')->defaultNull()->end()
+                        ->scalarNode('directory')->defaultValue('%kernel.cache_dir%/bernard')->end()
                         ->scalarNode('phpamqp_service')->defaultValue('old_sound_rabbit_mq.connection.default')->end()
                         ->scalarNode('phpamqp_exchange')->defaultNull()->end()
                         ->arrayNode('phpamqp_default_message_parameters')

diff --git a/README.md b/README.md
@@ -58,6 +58,7 @@ service definitions.
 ``` yaml
 my_receiver:
     class: Acme\Receiver
+    # public: true # Make sure the service is public
     tags:
          - { name: bernard.receiver, message: SendNewsletter }
          - { name: bernard.receiver, message: ImportUsers }

diff --git a/Tests/DependencyInjection/ConfigurationTest.php b/Tests/DependencyInjection/ConfigurationTest.php
@@ -26,7 +26,7 @@ public function testDefaults()
         $this->assertEquals([
             'prefetch'                           => null,
             'connection'                         => 'default',
-            'directory'                          => null,
+            'directory'                          => '%kernel.cache_dir%/bernard',
             'phpamqp_service'                    => 'old_sound_rabbit_mq.connection.default',
             'phpamqp_exchange'                   => null,
             'phpamqp_default_message_parameters' => [],
@@ -66,15 +66,6 @@ public function testPhpAmqpDriverRequiresExchangeOptionToBeSet()
         $this->processConfig(['driver' => 'phpamqp']);
     }
 
-    /**
-     * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
-     * @expectedExceptionMessage The "directory" option must be defined when using the "file" driver.
-     */
-    public function testFileDriverRequiresDirectoryOptionToBeSet()
-    {
-        $this->processConfig(['driver' => 'file']);
-    }
-
     /**
      * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
      * @expectedExceptionMessage The "ironmq_service" option must be defined when using the "ironmq" driver.