This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neverDefined
commented
Feb 20, 2023
- Setup precompiles
- Port over the staking precompile
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 86.98% 87.72% +0.73%
==========================================
Files 51 53 +2
Lines 1737 2101 +364
==========================================
+ Hits 1511 1843 +332
- Misses 191 214 +23
- Partials 35 44 +9
|
itsdevbear
reviewed
Feb 20, 2023
Looks bless so far ☃️🙏 |
itsdevbear
reviewed
Feb 22, 2023
@@ -78,8 +78,8 @@ func SetupMinimalKeepers() ( | |||
AccKey, | |||
authtypes.ProtoBaseAccount, | |||
map[string][]string{ | |||
stakingtypes.NotBondedPoolName: {authtypes.Minter, authtypes.Burner}, | |||
stakingtypes.BondedPoolName: {authtypes.Minter, authtypes.Burner}, | |||
stakingtypes.NotBondedPoolName: {authtypes.Minter, authtypes.Burner, authtypes.Staking}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats authtypes staking?
itsdevbear
approved these changes
Feb 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.