This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
feat(statedb): Reintroduce and simplify StateDB #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cal Bera <calbera@berachain.com> Signed-off-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: Cal Bera <calbera@berachain.com> Signed-off-by: Devon Bear <itsdevbear@berachain.com>
itsdevbear
commented
Jan 13, 2023
| // ============================================================================== | ||
|
|
||
| // `Revert` implements `journal.CacheEntry`. | ||
| func (ce *RefundChange) Revert() { |
There was a problem hiding this comment.
Maybe for the revert in the SDB we store a mapping of reflect.Type(RefundChange) to revert function with the signature of
func (sdb *StateDB) {}
Then in sdb RevertToSnapshot we have a for loop which goes through the journal.
There was a problem hiding this comment.
why iterate over types (map keys) instead of iterating over journal indices (journal keys are just slice indices) ?
There was a problem hiding this comment.
cuz these are all journal entries so its already taken care of
There was a problem hiding this comment.
yeah was just a thought, evm.go updates probably nil this.
Co-authored-by: Cal Bera <calbera@berachain.com>
Signed-off-by: Devon Bear <itsdevbear@berachain.com>
added 6 commits
January 13, 2023 18:07
Signed-off-by: Devon Bear <itsdevbear@berachain.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito