Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

chore(deps): bump cosmos-sdk to v0.50.2 and bump polaris-geth to v1.13.5 #1354

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

itsdevbear
Copy link

@itsdevbear itsdevbear commented Dec 13, 2023

Summary by CodeRabbit

  • Refactor

    • Updated transaction pool error handling to align with the latest Ethereum transaction pool package.
  • Chores

    • Improved codebase by replacing deprecated dependencies with current versions.

@itsdevbear itsdevbear added merge me daddy Trigger Beradozer to bulldoze the PR backport/v0.0.2-alpha labels Dec 13, 2023
@itsdevbear itsdevbear requested review from ocnc and calbera December 13, 2023 15:40
Copy link

coderabbitai bot commented Dec 13, 2023

Walkthrough

The changes involve an update to the mempool.go file in the Cosmos blockchain's runtime transaction pool. The update reflects a shift from using the legacy transaction pool package to a newer ethtxpool package from the Ethereum codebase. Additionally, an error check within the Insert function has been modified to align with this change, now referencing the ErrAlreadyKnown error from the new package.

Changes

File Change Summary
cosmos/runtime/txpool/mempool.go Updated import from legacypool to ethtxpool and changed error check to use ethtxpool.ErrAlreadyKnown.

🐇✨
In the code where bytes dance and twirl,
A rabbit hopped to a new import world.
From legacy past, to ethtxpool so bright,
Fixed an error check, and made the code right. 🌟
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c53168f and 4fafee2.
Files ignored due to filter (17)
  • build/tools/go.mod
  • build/tools/go.sum
  • contracts/go.mod
  • contracts/go.sum
  • cosmos/go.mod
  • cosmos/go.sum
  • e2e/localnet/go.mod
  • e2e/localnet/go.sum
  • e2e/precompile/go.mod
  • e2e/precompile/go.sum
  • e2e/testapp/go.mod
  • e2e/testapp/go.sum
  • eth/go.mod
  • eth/go.sum
  • go.work.sum
  • lib/go.mod
  • lib/go.sum
Files selected for processing (1)
  • cosmos/runtime/txpool/mempool.go (2 hunks)
Additional comments: 2
cosmos/runtime/txpool/mempool.go (2)
  • 37-38: The import change from legacypool to ethtxpool aligns with the PR's objective to update dependencies.

  • 111-111: The update to the error check in the Insert function to use ethtxpool.ErrAlreadyKnown is consistent with the updated import and the PR's objectives.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #1354 (4fafee2) into main (c53168f) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   48.63%   48.63%           
=======================================
  Files          84       84           
  Lines        4914     4914           
=======================================
  Hits         2390     2390           
  Misses       2347     2347           
  Partials      177      177           
Files Coverage Δ
cosmos/runtime/txpool/mempool.go 50.00% <0.00%> (ø)

@mergify mergify bot merged commit 3e15417 into main Dec 13, 2023
@mergify mergify bot deleted the bump-geth-sdk branch December 13, 2023 20:54
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
…o `v1.13.5` (#1354)

## Summary by CodeRabbit

- **Refactor**
  - Updated transaction pool error handling to align with the latest Ethereum transaction pool package.

- **Chores**
  - Improved codebase by replacing deprecated dependencies with current versions.

(cherry picked from commit 3e15417)
itsdevbear pushed a commit that referenced this pull request Dec 13, 2023
…o `v1.13.5` (backport #1354) (#1355)

This is an automatic backport of pull request #1354 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/v0.0.2-alpha merge me daddy Trigger Beradozer to bulldoze the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants