feat(test): Added test to call contract's read method

[hunter-bera]

Ran make test-hive, all test cases passed. Closes berachain/pm#6

Summary by CodeRabbit

• New Features

  • Enhanced smart contract interaction with additional output names for better clarity in read-only operations.

• Tests

  • Implemented new tests to ensure reliable contract read-only method functionality.

[coderabbitai]

Walkthrough

The changes involve updating a Go source file related to Ethereum's Hive testing framework. Specifically, the predeployedContractABI variable has been modified to enhance the definition of a contract function, and a new test function deployContractTest has been added to verify the read-only operations of a contract.

Changes

File Path	Change Summary
.../rpc/ethclient.hive	Updated predeployedContractABI to include additional output names and added deployContractTest for testing contract read-only methods.

Assessment against linked issues

Objective	Addressed	Explanation
#6: Ensure ethereum/hive tests cover all cases	✅	The addition of a new test function suggests an effort to increase test coverage, addressing the objective of vetting ethereum/hive tests for completeness.

Poem

As autumn leaves fall, a test is born anew, 🍂
CodeRabbit hops along, ensuring all is true. 🐇
With each line of code, the Hive grows strong,
In the dance of bits, nothing shall go wrong.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e922486 and fc8cb0d.

Files ignored due to filter (6)

• cosmos/go.mod
• cosmos/go.sum
• e2e/localnet/go.mod
• e2e/localnet/go.sum
• e2e/precompile/go.mod
• e2e/precompile/go.sum

Files selected for processing (1)

• e2e/hive/simulators/rpc/ethclient.hive (3 hunks)

Additional comments: 1

e2e/hive/simulators/rpc/ethclient.hive (1)

• 424-457: The new test function deployContractTest has been added to test the contract read-only method. The code looks correct, but ensure that the predeployedContractABI variable reflects the actual ABI of the deployed contract, including the correct output names for the constFunc function.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e922486 and 823aee4.

Files selected for processing (1)

• e2e/hive/simulators/rpc/ethclient.hive (3 hunks)

Additional comments: 4

e2e/hive/simulators/rpc/ethclient.hive (4)

• 3-3: The import for the bytes package is now present, resolving the previous issue.

• 69-69: The predeployedContractABI variable has been updated to include output names for the constFunc function, addressing the previous comment.

• 421-421: The error handling in deployContractTest is now consistent, using t.Fatalf for all error scenarios, which addresses the previous inconsistency issue.

• 424-457: The new test deployContractTest correctly deploys a contract and tests a read-only method. The test checks the return values against the expected values, ensuring the contract's read method works as intended.

[codecov]

Codecov Report

Merging #1324 (823aee4) into main (e922486) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1324   +/-   ##
=======================================
  Coverage   48.47%   48.47%           
=======================================
  Files          84       84           
  Lines        4871     4871           
=======================================
  Hits         2361     2361           
  Misses       2336     2336           
  Partials      174      174