Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

fix(evm): Use set instead of map while validating slots #125

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

calbera
Copy link
Contributor

@calbera calbera commented Feb 6, 2023

No description provided.

@calbera calbera requested a review from itsdevbear February 6, 2023 02:39
@itsdevbear
Copy link

faster?

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #125 (46db84c) into main (cea990e) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files          33       33           
  Lines        1118     1118           
=======================================
  Hits          991      991           
  Misses        115      115           
  Partials       12       12           
Impacted Files Coverage Δ
x/evm/plugin/state/storage/storage.go 100.00% <100.00%> (ø)

@calbera
Copy link
Contributor Author

calbera commented Feb 6, 2023

uses less memory, struct{} is 0 bytes, bool is 1 byte

@itsdevbear itsdevbear merged commit b30ea1e into main Feb 6, 2023
@itsdevbear itsdevbear deleted the storage-set branch May 3, 2023 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants