Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

feat: added more options for bentoctl build to match options available via buildx #190

Merged
merged 7 commits into from
Oct 6, 2022

Conversation

jjmachan
Copy link
Contributor

@jjmachan jjmachan commented Sep 6, 2022

Description

bentoctl build can now directly pass arguments supported by docker buildx. This gives more flexibility to the user in the build step.

image

closes:

@jjmachan jjmachan requested a review from aarnphm September 6, 2022 16:28
aarnphm
aarnphm previously approved these changes Sep 6, 2022
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, as long as this is in sync with bentoml containerize

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #190 (b23000f) into main (0a85290) will increase coverage by 0.13%.
The diff coverage is 68.25%.

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   59.05%   59.18%   +0.13%     
==========================================
  Files          24       22       -2     
  Lines        1138     1181      +43     
==========================================
+ Hits          672      699      +27     
- Misses        466      482      +16     
Flag Coverage Δ
unit-tests 59.18% <68.25%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/cli/__init__.py 76.92% <64.28%> (-8.14%) ⬇️
bentoctl/cli/utils.py 62.31% <100.00%> (+0.55%) ⬆️
bentoctl/deployment_config.py 68.50% <100.00%> (ø)
bentoctl/docker_utils.py 26.66% <100.00%> (+2.00%) ⬆️
bentoctl/utils/usage_stats.py 80.76% <100.00%> (+2.50%) ⬆️
bentoctl/utils/__init__.py
bentoctl/__init__.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjmachan
Copy link
Contributor Author

jjmachan commented Sep 7, 2022

I'm ok with this, as long as this is in sync with bentoml containerize

I will keep an eye out for that. Do you have any ideas on how we might be able to avoid this altogether maybe?

@jjmachan jjmachan requested a review from aarnphm September 29, 2022 04:51
aarnphm
aarnphm previously approved these changes Sep 29, 2022
@jjmachan jjmachan merged commit 148d231 into bentoml:main Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants