This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
feat: added more options for bentoctl build to match options available via buildx #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
previously approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this, as long as this is in sync with bentoml containerize
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 59.05% 59.18% +0.13%
==========================================
Files 24 22 -2
Lines 1138 1181 +43
==========================================
+ Hits 672 699 +27
- Misses 466 482 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I will keep an eye out for that. Do you have any ideas on how we might be able to avoid this altogether maybe? |
aarnphm
reviewed
Sep 7, 2022
aarnphm
previously approved these changes
Sep 29, 2022
9ac4091
to
b23000f
Compare
aarnphm
approved these changes
Oct 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bentoctl build
can now directly pass arguments supported bydocker buildx
. This gives more flexibility to the user in the build step.closes: