Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: materi hello world #25

Merged
merged 1 commit into from
Sep 29, 2021
Merged

add: materi hello world #25

merged 1 commit into from
Sep 29, 2021

Conversation

wildanie12
Copy link
Member

@wildanie12 wildanie12 commented Sep 29, 2021 •
edited
Loading

Closes #13

Deskripsi (Description)

  • saya menambahkan materi basic baru
  • saya memperbaiki materi basic yang sudah ada
  • saya menambahkan materi utility baru
  • saya memperbaiki materi utility sudah ada
  • saya menambahkan dokumentasi/artikel baru
  • saya memperbaiki dokumentasi/artikel yang sudah ada
  • saya menambahkan algoritma baru
  • saya memperbaiki algoritma yang sudah ada

Contributor Requirements (Syarat Kontributor)

  • saya sudah membaca (i have read) CONTRIBUTING dan sudah menyetujui semua
  • saya telah menambahkan docstring yang memberikan penjelasan maksud dari kode yang saya buat
  • saya sudah membuat artikel README.md tentang materi yang saya buat
  • saya menggunakan bahasa indonesia untuk memberikan penjelasan dari kode yang saya buat

Environment

saya menggunakan (im used):

  • os = windows

Testing

  • Codesniffer PSR-12 phpcs
  • Codesniffer autofix phpcbf
  • Unit testing PHPUnit

Maintainer

Mohon Reviewnya 🙏 :
@bellshade/php-team
@bellshade/docs-team

@wildanie12 wildanie12 requested a review from a team September 29, 2021 10:15
@nomadkode nomadkode added the documentation Improvements or additions to documentation label Sep 29, 2021
@nomadkode nomadkode requested a review from a team September 29, 2021 10:19
@wildanie12 wildanie12 added the enhancement New feature or request label Sep 29, 2021
wildanie12
wildanie12 commented Sep 29, 2021
View reviewed changes
Copy link
Member Author

@wildanie12 wildanie12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kalau dari saya sih bagus.. mantap bang Badar 👍

@nomadkode nomadkode removed the documentation Improvements or additions to documentation label Sep 29, 2021
@nomadkode
Copy link
Contributor

Kalau dari saya sih bagus.. mantap bang Badar 👍

wadooo, mention timnya om wkwk

@wildanie12
Copy link
Member Author

Kalau dari saya sih bagus.. mantap bang Badar 👍

wadooo, mention timnya om wkwk

Udah om wkwk .. saya merge aja kali yah, ini kan juga termasuk masih pertama kali

@wildanie12 wildanie12 merged commit 6452a9b into bellshade:main Sep 29, 2021
@wildanie12 wildanie12 deleted the hello_world branch September 29, 2021 11:02
feri-irawan
feri-irawan reviewed Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@feri-irawan feri-irawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantap!! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feri-irawan feri-irawan feri-irawan left review comments

@hendraaagil hendraaagil hendraaagil approved these changes

Assignees

@wildanie12 wildanie12

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Materi Basic: Hello World
4 participants
@wildanie12 @nomadkode @hendraaagil @feri-irawan