Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundand disease matching #47

Merged
merged 7 commits into from
Mar 8, 2025

Conversation

mathieulemieux
Copy link
Member

No description provided.

@mathieulemieux mathieulemieux self-assigned this Feb 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 86.07%. Comparing base (e6e48c5) to head (c96d7e1).

Files with missing lines Patch % Lines
pori_python/ipr/ipr.py 50.00% 7 Missing ⚠️
pori_python/ipr/annotate.py 50.00% 2 Missing ⚠️
pori_python/ipr/main.py 50.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #47      +/-   ##
===========================================
- Coverage    86.26%   86.07%   -0.20%     
===========================================
  Files           18       18              
  Lines         2388     2398      +10     
===========================================
+ Hits          2060     2064       +4     
- Misses         328      334       +6     
Flag Coverage Δ
unittests 86.07% <50.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathieulemieux
Copy link
Member Author

Some overall speed gain (~5-10%) over report creation by matching the disease once instead of on every statement matching.

@mathieulemieux mathieulemieux marked this pull request as ready for review March 4, 2025 19:15
@mathieulemieux mathieulemieux merged commit 106f4c3 into develop Mar 8, 2025
8 of 9 checks passed
@mathieulemieux mathieulemieux mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants