Add BC Sans font, apply to style.css, increment version #98
+31
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the BC Sans web font to the assets of new SMK apps (both default and mobile) and updates style.css to set BC Sans as the font family.
dgboss
approved these changes
May 19, 2022
| } | ||
|
|
||
| button, input { | ||
| font-family: 'BC Sans',Helvetica,Arial,sans-serif; |
There was a problem hiding this comment.
Consider setting the font-family for buttons to 'inherit' in order to make updating the app wide font a little easier for users.
font-family: inherit
| } | ||
|
|
||
| button, input { | ||
| font-family: 'BC Sans',Helvetica,Arial,sans-serif; |
There was a problem hiding this comment.
Same here, consider font-family: inherit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the BC Sans web font to the assets of new SMK apps (both default and mobile) and updates style.css to set BC Sans as the font family.
This also updates the version as well as the SMK dependency version, to consume an SMK release that better supports BC Sans styling.