Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback of contentType for a fileType value #82

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

Jonesy
Copy link
Contributor

@Jonesy Jonesy commented Feb 25, 2019

Description

Some file uploads lose their filetype value post upload. This PR has a fallback if there is no filetype it will either try and show the content-type or unknown if nothing exists on the metadata for the file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Jonesy Jonesy requested a review from jujaga February 25, 2019 18:21
Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jujaga jujaga merged commit 25642bc into develop Feb 25, 2019
@jujaga jujaga deleted the hotfix/issue-74 branch February 25, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants