Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple file uploads breaking which files are saved to request #70

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Fix multiple file uploads breaking which files are saved to request #70

merged 1 commit into from
Feb 21, 2019

Conversation

Jonesy
Copy link
Contributor

@Jonesy Jonesy commented Feb 21, 2019

Description

The autosave to a request after each successful file upload would only save the last file uploaded and would overwrite previously uploaded files, reducing the total saved to the request to just one. Instead of saving the file as a side effect in the upload saga the upload is triggered by the form component once the isUploading flag is turned off.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Jonesy
Try a different approach to autosave so that files don't get written …
548e3b1 
…over by multiple PUT requests during each upload completion.
jujaga
jujaga approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me.

BrandonSharratt
BrandonSharratt approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@BrandonSharratt BrandonSharratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested locally

@BrandonSharratt BrandonSharratt merged commit 691fde6 into develop Feb 21, 2019
@jujaga jujaga deleted the hotfix/issue-65 branch February 21, 2019 19:56
@pripley123
Copy link
Collaborator

Successfully tested in test environment

@pripley123 pripley123 added the verification Verify the bug has been fixed label Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jujaga jujaga jujaga approved these changes

@BrandonSharratt BrandonSharratt BrandonSharratt approved these changes

Assignees
No one assigned
Labels
verification Verify the bug has been fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jonesy @pripley123 @jujaga @BrandonSharratt