Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build issue resolution and security update on package management #63

Merged
merged 12 commits into from
Feb 16, 2019
Merged

Docker build issue resolution and security update on package management #63

merged 12 commits into from
Feb 16, 2019

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Feb 15, 2019

Description

snyk protect works, but fails in the Docker build. We need to remove it to ensure deployment actually proceeds instead of soft failing.
Also an array of security vulnerabilities were patched by updating our dependencies and npm audit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

BrandonSharratt and others added 6 commits February 15, 2019 09:34
@BrandonSharratt
actually call the notifications in forumApi
ef264bb
@BrandonSharratt
Merge branch 'develop' of https://github.com/bcgov/OCWA into develop
fd13363
@BrandonSharratt
Fixed frontend docker image proble,
06e572d
@jujaga
Fix/testdependencies (#59)
d1747ad 
* dependency-checker to sonarcloud
* Force npm audit
* Fix npm audit issues with frontend packages
* express-manifest update in frontend
* Update sonar-project.properties
* Update package.json
* Updated yarn lock
* added express-manifest-helpers-upgraded
* Upgrade express-manifest-helpers version
@jujaga
Update package-lock.json for forumApi and requestApi
b24aabb 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@BrandonSharratt
Snyk protect which isn't in the docker file breaks the dockerfile, fu…
466712f 
…lly removing
@jujaga jujaga changed the title Merge in Docker build issue resolutions from develop Docker build issue resolution and security update on package management Feb 15, 2019
@BrandonSharratt BrandonSharratt merged commit e3f5647 into master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jujaga @BrandonSharratt