Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sonar #277

Merged
merged 75 commits into from
Feb 6, 2020
Merged

Fix/sonar #277

merged 75 commits into from
Feb 6, 2020

Conversation

BrandonSharratt
Copy link
Contributor

Description

Added a lot more tests, fixed some smells, code duplication and some small bugs in currently unused api routes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@BrandonSharratt BrandonSharratt changed the base branch from master to develop February 6, 2020 17:42
@BrandonSharratt BrandonSharratt merged commit a76d06a into develop Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants