Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the details component to be a little more polymorphic. #276

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Adjust the details component to be a little more polymorphic. #276

merged 1 commit into from
Feb 11, 2020

Conversation

Jonesy
Copy link
Contributor

@Jonesy Jonesy commented Jan 31, 2020

Description

Adds checkbox and radio button support to the read only request details view.

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Jonesy Jonesy requested a review from ikethecoder January 31, 2020 18:32
BrandonSharratt
BrandonSharratt approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@BrandonSharratt BrandonSharratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@BrandonSharratt BrandonSharratt merged commit e897616 into develop Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonSharratt BrandonSharratt BrandonSharratt approved these changes

@ikethecoder ikethecoder Awaiting requested review from ikethecoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonesy @BrandonSharratt