Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end error reporting and logging #263

Merged
merged 17 commits into from
Feb 12, 2020

Conversation

Jonesy
Copy link
Contributor

@Jonesy Jonesy commented Dec 13, 2019

Description

Users need more information from the UI to explain why a bug failed and developers need more details from the system when errors do happen. This PR adds the ability for users to report additional details when experiencing a UI failure and logs are stored in frontend/server/logs with Express messages and the current state of the Redux store when the error occurred.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@bdolor
Copy link
Contributor

bdolor commented Feb 7, 2020

any barriers to merging?

@@ -40,10 +40,23 @@ const exporterMode = config.get('exporterMode');
const codeExportEnabled = config.get('codeExportEnabled');
const repositoryHost = config.get('repositoryHost');

log.level = 'debug'; // config.get('logLevel');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this hardcoded to debug?

@Jonesy Jonesy force-pushed the feature/issue-251-error-reporting branch from 705fcc4 to 796e183 Compare February 11, 2020 23:21
@BrandonSharratt BrandonSharratt merged commit 38c75d5 into develop Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants